Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Clp] Add v1.17.6 #837

Merged
merged 2 commits into from
Apr 14, 2020
Merged

[Clp] Add v1.17.6 #837

merged 2 commits into from
Apr 14, 2020

Conversation

odow
Copy link
Contributor

@odow odow commented Apr 12, 2020

Contains a bug-fix for coin-or/Clp#142

cc @ViralBShah is this all I need to do for a release?

@amontoison
Copy link
Contributor

No, you also need to update the build_tarballs.jl of Clp to trigger the compilation.
You can remove the comma at the end of this line : https://github.com/JuliaPackaging/Yggdrasil/blob/master/C/Coin-OR/Clp/build_tarballs.jl#L9

@ViralBShah
Copy link
Member

ViralBShah commented Apr 12, 2020 •
edited
Loading

I don't understand why BB can't find that commit. This is the right release:

coin-or/Clp@756ddd3

Removing C/Coin-OR/Clp/build
Cleaning C/Coin-OR/Clp/products
[ Info: Building for x86_64-linux-musl-cxx03
   Updating registry at `/depot/registries/General`
   Updating git-repo `https://github.com/JuliaRegistries/General.git`
25l25h[ Info: Cloning Clp.git to srcdir...
ERROR: LoadError: GitError(Code:ENOTFOUND, Class:Odb, object not found - no match for id (756ddd3ed813eb1fa8b2d1b4fe813e6a4d7aa1eb))
Stacktrace:
 [1] macro expansion at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.4/LibGit2/src/error.jl:101 [inlined]
 [2] LibGit2.GitObject(::LibGit2.GitRepo, ::LibGit2.GitHash) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.4/LibGit2/src/repository.jl:158
 [3] checkout!(::LibGit2.GitRepo, ::String; force::Bool) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.4/LibGit2/src/LibGit2.jl:510
 [4] checkout! at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.4/LibGit2/src/LibGit2.jl:494 [inlined]
 [5] #48 at /depot/packages/BinaryBuilder/RgjsE/src/Prefix.jl:270 [inlined]
 [6] with(::BinaryBuilder.var"#48#49"{BinaryBuilder.SetupSource{GitSource}}, ::LibGit2.GitRepo) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.4/LibGit2/src/types.jl:1125
 [7] setup(::BinaryBuilder.SetupSource{GitSource}, ::String, ::Bool) at /depot/packages/BinaryBuilder/RgjsE/src/Prefix.jl:269
 [8] setup_workspace(::String, ::Array{BinaryBuilder.SetupSource{GitSource},1}; verbose::Bool) at /depot/packages/BinaryBuilder/RgjsE/src/Prefix.jl:358
 [9] autobuild(::AbstractString, ::AbstractString, ::VersionNumber, ::Array{#s1082,1} where #s1082<:BinaryBuilder.AbstractSource, ::AbstractString, ::Array{T,1} where T, ::Array{#s1081,1} where #s1081<:Product, ::Array{#s1080,1} where #s1080<:BinaryBuilder.AbstractDependency; verbose::Bool, debug::Bool, skip_audit::Bool, ignore_audit_errors::Bool, autofix::Bool, code_dir::Union{Nothing, String}, require_license::Bool, lazy_artifacts::Bool, meta_json_stream::Any, kwargs::Any) at /depot/packages/BinaryBuilder/RgjsE/src/AutoBuild.jl:592
 [10] build_tarballs(::Any, ::Any, ::Any, ::Any, ::Any, ::Any, ::Any, ::Any; kwargs::Any) at /depot/packages/BinaryBuilder/RgjsE/src/AutoBuild.jl:183
 [11] top-level scope at /agent/_work/1/s/C/Coin-OR/Clp/build_tarballs.jl:62
 [12] include(::Module, ::String) at ./Base.jl:377
 [13] exec_options(::Base.JLOptions) at ./client.jl:288
 [14] _start() at ./client.jl:484
in expression starting at /agent/_work/1/s/C/Coin-OR/Clp/build_tarballs.jl:62

@ViralBShah ViralBShah closed this Apr 12, 2020
@ViralBShah ViralBShah reopened this Apr 12, 2020
@giordano
Copy link
Member

Use an ArchiveSource instead? 🙂 I know I'm an outlier in this, but I'm not a fan of using GitSource.

@ViralBShah
Copy link
Member

The main benefit of GitSource is that it is fewer steps because you don't need to compute the sha256. But ArchiveSource is certainly less error-prone.

@ViralBShah
Copy link
Member

The way the coin-or builds are set up, I'll have to switch them all - so perhaps that will have to be a separate PR. In the meanwhile, I will leave this open if someone can point out what might be going on with GitSource.

@giordano
Copy link
Member

The interesting thing is that locally it works for me and compilation (at least for x86_64-linux-gnu) is successfull

@ViralBShah
Copy link
Member

@staticfloat Any thoughts?

@giordano
Copy link
Member

giordano commented Apr 12, 2020 •
edited
Loading

My guess is that since this a recent commit, the LibGit2.fetch call in https://github.com/JuliaPackaging/BinaryBuilder.jl/blob/15fb9ba3c42c2528226cd09732ac454cd5a460d8/src/Sources.jl#L149-L154 may not be getting the new revision. Removing the git repo in the cache could probably help (or at least test my hypothesis)

@ViralBShah
Copy link
Member

ViralBShah commented Apr 12, 2020 •
edited
Loading

My guess is that since this a recent commit, the LibGit2.fetch call in https://github.com/JuliaPackaging/BinaryBuilder.jl/blob/15fb9ba3c42c2528226cd09732ac454cd5a460d8/src/Sources.jl#L149-L154 may not be getting the new revision. Removing the git repo in the cache could probably help (or at least test my hypothesis)

Can I remove the git repo in the cache? How would I do that? That certainly seems like a plausible explanation. This could be a widespread problem across a number of packages - and perhaps needs a BB fix.

@giordano
Copy link
Member

Can I remove the git repo in the cache? How would I do that?

I think that requires access to the machine.

@ViralBShah ViralBShah mentioned this pull request Apr 13, 2020
Closed
@staticfloat
Copy link
Member

I nuked Clp.git; is it possible you changed upstream git repo?

@staticfloat staticfloat reopened this Apr 13, 2020
@ViralBShah
Copy link
Member

I nuked Clp.git; is it possible you changed upstream git repo?

I don't think so.

@ViralBShah ViralBShah merged commit 78031a8 into JuliaPackaging:master Apr 14, 2020
@odow odow deleted the patch-1 branch April 14, 2020 17:13
@odow odow mentioned this pull request Jul 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@odow @amontoison @ViralBShah @giordano @staticfloat